openSourceUrl($url) must be compatible

Created on 21 July 2023, over 1 year ago

Problem/Motivation

Cannot run example migration in Php 8.

ddev drush ms --group=migration_tools_example
PHP Fatal error: Declaration of Drupal\migration_tools\Plugin\migrate_plus\data_parser\Dom::openSourceUrl($url) must be compatible with Drupal\migrate_plus\DataParserPluginBase::openSourceUrl(string $url): bool in /var/www/html/docroot/modules/contrib/migration_tools/src/Plugin/migrate_plus/data_parser/Dom.php on line 93

Steps to reproduce

* enable example module
* run above code
* confirm error

Proposed resolution

* Add return type to DOM class

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States robpowell Boston

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @robpowell
  • @robpowell opened merge request.
Production build 0.71.5 2024