Failing to select Currency when adding Contribution on civi tab results in no warning and nothing saved

Open on Drupal.org →

Created on 21 July 2023, over 1 year ago

Updated 6 August 2023, over 1 year ago

1.0 Problem/Motivation

I just tried setting up a webfor with civi and when clicking SAVE nothing was happening.

Log reports shows

Location https://iussp.org/en/admin/structure/webform/manage/pd1_join/civicrm?_wr...
Referrer https://iussp.org/en/admin/structure/webform/manage/pd1_join/civicrm
Message Warning: Undefined array key "civicrm_1_contribution_1_contribution_financial_type_id" in Drupal\webform_civicrm\AdminForm->buildContributionTab() (line 1095 of /srv/www/iussp/iussp.org/web/modules/contrib/webform_civicrm/src/AdminForm.php)
#0 /srv/www/iussp/iussp.org/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
#1 /srv/www/iussp/iussp.org/web/modules/contrib/webform_civicrm/src/AdminForm.php(1095): _drupal_error_handler()
#2 /srv/www/iussp/iussp.org/web/modules/contrib/webform_civicrm/src/AdminForm.php(123): Drupal\webform_civicrm\AdminForm->buildContributionTab()
#3 /srv/www/iussp/iussp.org/web/modules/contrib/webform_civicrm/src/Form/WebformCiviCRMSettingsForm.php(54): Drupal\webform_civicrm\AdminForm->buildForm()
#4 [internal function]: Drupal\webform_civicrm\Form\WebformCiviCRMSettingsForm->buildForm()
#5 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array()
#6 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Form/FormBuilder.php(375): Drupal\Core\Form\FormBuilder->retrieveForm()
#7 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Form/FormBuilder.php(633): Drupal\Core\Form\FormBuilder->rebuildForm()
#8 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm()
#9 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#10 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#11 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#12 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/Render/Renderer.php(583): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#13 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext()
#14 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#15 /srv/www/iussp/iussp.org/vendor/symfony/http-kernel/HttpKernel.php(166): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#16 /srv/www/iussp/iussp.org/vendor/symfony/http-kernel/HttpKernel.php(74): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#17 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#18 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#19 /srv/www/iussp/iussp.org/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#20 /srv/www/iussp/iussp.org/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#21 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#22 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#23 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#24 /srv/www/iussp/iussp.org/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#25 /srv/www/iussp/iussp.org/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#26 {main}

I see no mention of Currency on there, but when i reviewed the form I saw it had not been set to anything, and then it saved.

🐛 Bug report

Status

Fixed

Version

6.2

Component

Webform/Drupal

Created by

🇳🇿New Zealand petednz

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @petednz
Status changed to Needs review over 1 year ago6:57am 23 July 2023
Comment over 1 year ago →
🇮🇳India jitendrapurohit
Have raised a PR to set a default value for the currency field - https://github.com/colemanw/webform_civicrm/pull/896

I think this will set the currency on the contribution tab and will avoid submitting the empty currency field?

Can you please review it?

Thanks.
Comment over 1 year ago →
🇳🇿New Zealand petednz
While I now suspect the above error did not result from not having set currency (since our subsequent testing kept giving us no error and the pop up to tell us it was a required field) i do think that setting currency to default is helpful. we tested. it worked
Status changed to RTBC over 1 year ago7:21am 24 July 2023
Comment over 1 year ago →
🇳🇿New Zealand petednz
Status changed to Fixed over 1 year ago7:36am 6 August 2023
Comment over 1 year ago →
🇮🇳India jitendrapurohit
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024