- Issue created by @penyaskito
- 🇪🇸Spain gadroher
I have created a test for edit dashboard action that the dashboard contains a form block, add a new block and save, it shows the proper status message.
- Status changed to Needs review
over 1 year ago 12:19pm 1 August 2023 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Found this was an issue at some point for content layout builder.
This was fixed in DefaultsEntityForm, but wondering if it should be fixed up in the inheritance chain, as this is probably affecting any layout builder form.Attached patch. See https://git.drupalcode.org/project/drupal/-/commit/0a16b0f112 for a potential browser test.
- Assigned to yanniboi
- 🇬🇧United Kingdom yanniboi UK
I am assigning this to myself and will try to work on this during DrupalCon Lille. If I dont make any progress I will unassign myself again.
- Status changed to RTBC
about 1 year ago 1:24pm 18 October 2023 - 🇪🇸Spain plopesc Valladolid
Thank you @penyaskito!
Tested the patch and it solves the issue.
Marking as RTBC unless you consider to add some tests for it.
Feel free to move it back to Needs Work if so.
- 🇬🇧United Kingdom yanniboi UK
I'm attaching a js test to cover the changing and saving of a dashboard with a form block present.
- 🇬🇧United Kingdom yanniboi UK
Tests are failing/passing as expected:
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Test look great! Thanks Yan!
+++ b/tests/modules/dashboard_test/config/install/dashboard.dashboard.test.yml @@ -0,0 +1,38 @@ +dependencies: { }
I don't think we should change anything here now, but this helped me figuring out 📌 [PP-1] If a dashboard uses layout builder, add the config dependency Active
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Added credit for people that worked on this in Vienna and providing reviews.
- Status changed to Fixed
about 1 year ago 1:20pm 19 October 2023 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Pushed to 1.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
11 months ago 11:36am 10 January 2024