- Issue created by @marceloostdijk
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
almost 2 years ago 1 pass - @marceloostdijk opened merge request.
- Status changed to RTBC
almost 2 years ago 11:55am 24 July 2023 - 🇮🇳India keshavv India
I have checked the MR and confirmed that It is working perfectly, Because
use Drupal\Core\Http\RequestStack;is deprecated
so it will encounter the error.
https://www.drupal.org/node/3265357 →We can go with the MR.
Thank you. - Status changed to Needs review
almost 2 years ago 10:18am 26 July 2023 - 🇸🇮Slovenia useernamee Ljubljana
I've reproduced the issue on d10. Code change fixes the issue.
I've tested it on d9.5 - code change doesn't broke the controller output.I'm a bit vary about the d8 compatibility but currently I don't have capacity to test.
- last update
almost 2 years ago 1 pass -
useernamee →
committed 34f32d02 on 1.x authored by
marceloostdijk →
Issue #3375906: TypeError: Drupal\ohdear_integration\Controller\...
-
useernamee →
committed 34f32d02 on 1.x authored by
marceloostdijk →
- Status changed to Fixed
almost 2 years ago 1:42pm 26 July 2023 - 🇸🇮Slovenia useernamee Ljubljana
d9 and d10 tests are passing.
merged & doneWill be part of next release (not sure when this will happen).
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 4:56pm 15 August 2023