- Issue created by @jennypanighetti
- 🇮🇳India shailja179 India
I didn't find this error with this version of smart trim. This is working fine and More link is showing properly and working too.
Attaching the screenshot. - 🇺🇸United States chucksimply
For me, it's only when using this module in conjunction with Smart Trim 2.1.0. Can you confirm the Smart Trim version you're using?
- Status changed to RTBC
about 1 year ago 6:37pm 8 November 2023 - 🇺🇸United States chucksimply
So I can confirm this issue occurs when upgrading Smart Trim to 2.1.0. The patch in #2 works great. Can we get this in a new release?
- Merge request !3[#3375395] Make formatter compatible with Smart Trim to 2.1 → (Open) created by HitchShock
- Status changed to Needs review
about 1 year ago 4:45pm 24 November 2023 - 🇺🇦Ukraine HitchShock Ukraine
Reviewed the solution one more time and made a conclusion that it was not enough to fix the compatibility with Smart Trim to 2.1.
For that, we need:
- update the formatter from the Smart Trim module - copy new logic to our formatter
- implement an upgrade path as Smart Trim did - a similar hook_update
- also, we need to implement a schema for our formatter settings - 🇫🇮Finland anaconda777
Hi,
Patch #2 worked for me, the #8 did not apply with composer.