Disabling the webform_civicrm handler doesn't prevent it from being called

Created on 18 July 2023, 12 months ago

Updated 23 July 2023, 11 months ago

1.0 Problem/Motivation

Disabling the webform_civicrm handler doesn't prevent it from being called. In webform_civicrm.module, webform_civicrm_webform_submission_load() there are still hooks that call webform_civicrm functionality even if the handler is disabled. Worse, it can no longer find civicrm_api3().

2.0 Detailed steps to reproduce (embed screenshots)

Check the webform's handlers in webform_civicrm_webform_submission_load(). There may be others, such as webform_civicrm_element_info_alter() and webform_civicrm_webform_autocomplete_options_alter().

3.0 Proposed resolution

Check if the handler is active.

🐛 Bug report

Status

Needs work

Version

6.0

Component

Code

Created by

🇨🇦Canada nubeli

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @nubeli
Status changed to Needs review 12 months ago3:34am 19 July 2023
Comment 12 months ago →
🇨🇦Canada nubeli
PR: https://github.com/colemanw/webform_civicrm/pull/894 - it check if handler is enabled in _fillCiviCRMData(). This at least seems to ensure that the webform_civicrm service isn't called.
Status changed to Needs work 11 months ago7:38am 23 July 2023
Comment 11 months ago →
🇮🇳India jitendrapurohit
Hi @nubeli. I've reviewed & commented on the PR. Can you please have another look? Seems like there are more places that needs handling after civicrm handler is disabled.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024