PHPStand level 6 fixes

Issue created by @jurgenhaas
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
294 pass, 2 fail
@jurgenhaas opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
296 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
296 pass
Issue was unassigned.
Status changed to Needs review over 1 year ago11:08am 18 July 2023

🇩🇪Germany jurgenhaas Gottmadingen

This is ready for a review, although we still have some issues reported by PhpStan:

 ------ --------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/form/eca_form.module
 ------ --------------------------------------------------------------------------------------------------------------------------------------
  40     Function eca_form_field_widget_single_element_inline_entity_form_complex_form_alter() has parameter $context with no type specified.
  40     Function eca_form_field_widget_single_element_inline_entity_form_complex_form_alter() has parameter $element with no type specified.
 ------ --------------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------
  Line   modules/render/src/Plugin/views/field/EcaRender.php
 ------ -----------------------------------------------------------------------------------------------------------------------
  63     Method Drupal\eca_render\Plugin\views\field\EcaRender::buildOptionsForm() has parameter $form with no type specified.
 ------ -----------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------
  Line   src/Plugin/DataType/DataTransferObject.php
 ------ -------------------------------------------------------------------------------------------------------------------------
  413    Method Drupal\eca\Plugin\DataType\DataTransferObject::writePropertyValue() has parameter $value with no type specified.
 ------ -------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------
  Line   src/PluginManager/Action.php
 ------ ---------------------------------------------------------------------------------------------------------------
  95     Method Drupal\eca\PluginManager\Action::setCacheBackend() has no return type specified.
  132    Method Drupal\eca\PluginManager\Action::clearCachedDefinitions() has no return type specified.
  140    Method Drupal\eca\PluginManager\Action::useCaches() has no return type specified.
  148    Method Drupal\eca\PluginManager\Action::processDefinition() has no return type specified.
  148    Method Drupal\eca\PluginManager\Action::processDefinition() has parameter $definition with no type specified.
  148    Method Drupal\eca\PluginManager\Action::processDefinition() has parameter $plugin_id with no type specified.
 ------ ---------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------
  Line   src/Token/ContribToken.php
 ------ --------------------------------------------------------------------------------------------------------
  34     Method Drupal\eca\Token\ContribToken::getTypeInfo() has parameter $token_type with no type specified.
  41     Method Drupal\eca\Token\ContribToken::getTokenInfo() has parameter $token with no type specified.
  41     Method Drupal\eca\Token\ContribToken::getTokenInfo() has parameter $token_type with no type specified.
 ------ --------------------------------------------------------------------------------------------------------

Those can't be corrected since their interface's declarations are similar to the current usage and hence, we can't change them. Guess, this has to be reported to PhpStan as a bug.

Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
296 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
296 pass
Status changed to RTBC over 1 year ago11:05am 19 July 2023
Comment over 1 year ago →
🇩🇪Germany jurgenhaas Gottmadingen
We've looked at this at #ddd2023 and since all tests are green, let's go for it. Can then also be the basis for the new 2.0 branch.
Comment over 1 year ago →
System Message

jurgenhaas → committed 776e9526 on 1.2.x
Issue #3375167: PHPStand level 6 fixes
Status changed to Fixed over 1 year ago11:06am 19 July 2023
Comment over 1 year ago →
🇩🇪Germany jurgenhaas Gottmadingen
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Comments & Activities