css_defer setting broken with Drupal 10.1

Open on Drupal.org →

Created on 17 July 2023, over 1 year ago

Updated 20 October 2023, about 1 year ago

Problem/Motivation

The regexp in DeferCss::defer() does not work anymore with Drupal 10.1 because the format of asset URLs changed.

Steps to reproduce

Enable Deferred CSS Execution and Inline javascript loader library in advagg_mod.
Enable CSS preprocessing in core.
<link> tags are not replace by the regexp.

Proposed resolution

The regexp should be tweaked to work with the new URL format.

(Note that this regexp also causes 🐛 Content is not well-formed on 404 page Needs review so it might be better to switch to real DOM parsing.)

🐛 Bug report

Status

Needs review

Version

6.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @prudloff
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
54 pass
@prudloff opened merge request.
Status changed to Needs review over 1 year ago4:01pm 17 July 2023
Comment over 1 year ago →
🇫🇷France prudloff Lille
Comment about 1 year ago →
🇫🇷France prudloff Lille
🐛 css_defer_external option does not work if CSS URL contains characters not allowed by the regex Needs review started converting the logic to use DOM instead of a regexp, so we should probably focus on getting that committed and then we can check if the current issue still applies.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024