Provide upgrade path for the "node_type" condition

Thanks for the patch. It is working as expected in my project. Steps followed:

• Applied the patch using composer
• Ran drush updb
• Cleared the Cache

Worked for me, as well.

The updated works great for the node_type however there are more updates to be done as the current_theme is not single and not multiple also causes issues. Unfortunately it is not possible to make separate updates when there are configs with both node_type and current_theme conditions so I added that as well.

+1 RTBC for #3 — it's working great for us.

RE #6 — It seems like this should be a separate issue, and I'd question:

• Where did the invalid current_theme config (i.e. an array) come from?
• Why can't that config change be handled in a separate update?

Not sure when the condition for current_theme got changed but before it was array now it is single.
It cannot be put in separate update because once you have conditions with both node_type and current_theme which is a case we had it is impossible to run the update as its validation will fail either on node_type or on current theme.

The current_theme issue was noted in https://www.drupal.org/project/asset_injector/issues/3329577#comment-148... 🐛 Fatal error: Schema error for theme condition selection field Fixed

Note that the current_theme was still working with multiple values, but it was causing errors when saving. That was "fixed" with this commit. At the time of fixing that, there wasn't a need to provide an update hook since the conditions still worked. If that is no longer the case, please open a new issue.

Just a note that #6 is a real issue, and the way to work around it within this particular update hook (where the asset injector might still have other incorrectly configured properties e.g. multiple themes) is to update the update hook with:

      $asset_injector_config
        ->set('conditions', $conditions)
        ->save(TRUE);

This ensures that the validation checks aren't ran on save. Leaving a chance for a new ticket/update hook as specified by @pookmish to handle the theme specific stuff.

I'd recommend pushing a new commit which does a save with TRUE.

codebymikey → closed merge request !11

Ahh thank you @codebymikey

Automatically closed - issue fixed for 2 weeks with no activity.