Add support for GD

Created on 17 July 2023, over 1 year ago

Problem/Motivation

GD now supports AVIF : https://php.watch/versions/8.1/gd-avif
It would be nice if it could be used in this module.

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @prudloff
  • Merge request !9Issue #3375023: Add support for GD → (Open) created by prudloff
  • 🇫🇷France prudloff Lille

    This would require the patch from Let GDToolkit support AVIF image format Needs work in order to work.

  • Status changed to Needs work over 1 year ago
  • 🇦🇺Australia mstrelan

    The quality setting seems to have no effect. If I set it to 1, 60 or 90 I get the same result.

  • Merge request !11Issue #3375023: Add support for GD → (Open) created by mstrelan
  • 🇦🇺Australia mstrelan

    Added a new MR that includes 📌 Test coverage Needs review so we can test this. It will fail until Let GDToolkit support AVIF image format Needs work is in, but we could see if we can apply a patch in the meantime.

  • Pipeline finished with Failed
    over 1 year ago
    Total: 187s
    #21887
  • Pipeline finished with Success
    over 1 year ago
    Total: 2045s
    #22237
  • Pipeline finished with Success
    over 1 year ago
    Total: 154s
    #22249
  • Pipeline finished with Success
    over 1 year ago
    Total: 153s
    #23207
  • Pipeline finished with Success
    over 1 year ago
    Total: 155s
    #23239
  • Status changed to Needs review over 1 year ago
  • 🇦🇺Australia mstrelan

    I think this is good to go in as it is without waiting for core. If the core toolkit does not support avif then we'll get the "Your image toolkit gd doesn't support AVIF format" message in the logs. I've opened 📌 Prevent selection of unsupported toolkits Active to prevent it being selected when it's not supported.

    I think the image quality issue should be addressed separately. We are passing the quality as a parameter to \Drupal\system\Plugin\ImageToolkit\Operation\gd\Convert::execute but GdToolkit ignores it.

  • Pipeline finished with Success
    over 1 year ago
    Total: 249s
    #24881
  • Pipeline finished with Failed
    over 1 year ago
    Total: 225s
    #26425
  • Pipeline finished with Failed
    over 1 year ago
    Total: 156s
    #26434
  • Pipeline finished with Success
    over 1 year ago
    Total: 214s
    #26443
  • Pipeline finished with Success
    over 1 year ago
    Total: 188s
    #26461
  • Pipeline finished with Success
    over 1 year ago
    Total: 162s
    #26473
  • Pipeline finished with Success
    over 1 year ago
    Total: 155s
    #26480
  • Pipeline finished with Success
    over 1 year ago
    Total: 155s
    #26494
  • Status changed to Needs work over 1 year ago
  • 🇦🇺Australia nterbogt

    This change is supported at a functional level. But I don't think we should merge it until the bug in core is fixed... or 📌 Prevent selection of unsupported toolkits Active is implemented and merged and we can detect that you have the required patch.

    For ease of finding, core patch listed above is Let GDToolkit support AVIF image format Needs work

  • Pipeline finished with Success
    over 1 year ago
    Total: 163s
    #28956
  • Status changed to Postponed about 2 months ago
  • 🇦🇺Australia mstrelan

    Tried to rebase but too many issues, merged in 1.1.x and resolve the conflict on composer.json

    Postponing on Let GDToolkit support AVIF image format Needs work anyway

  • Pipeline finished with Success
    about 2 months ago
    Total: 229s
    #403203
  • Pipeline finished with Success
    about 2 months ago
    Total: 198s
    #403204
  • 🇦🇺Australia mstrelan

    Core issue landed so this is no longer postponed.

  • 🇫🇷France prudloff Lille

    prudloff changed the visibility of the branch 3375023-add-support-for to hidden.

  • Pipeline finished with Success
    8 days ago
    Total: 282s
    #438370
Production build 0.71.5 2024