\Drupal calls should be avoided in classes, use dependency injection instead

Created on 17 July 2023, almost 2 years ago

Problem/Motivation

FILE: /home/lenovo/d7to9/web/modules/contrib/acsf/acsf_theme/src/Commands/AcsfThemeCommands.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 65 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/acsf/acsf_duplication/src/Commands/AcsfDuplicationCommands.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------
  71 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 114 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 132 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/acsf/acsf_variables/src/Commands/AcsfVariablesCommands.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERROR AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------------------------------------------------------
  35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  93 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 119 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 127 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 150 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 158 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 181 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/acsf/acsf_sso/src/EventSubscriber/SamlauthUserSyncSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 105 | WARNING | Role::load calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig acsf/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs review

Version

2.73

Component

Code

Created by

🇮🇳India roshni27

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024