- Issue created by @_tarik_
- @_tarik_ opened merge request.
- Status changed to Needs review
over 1 year ago 9:19pm 13 July 2023 - πΊπ¦Ukraine _tarik_ Lutsk
Summary of the provided changes:
- Overided several services from JSON:API
- Removed event subscriber
- Updated configuration form
- Added hook update to update module configuration
As I mentioned in the issue description these changes too much depend to inner structure of JSON:API.
This is the start of work on this issue and I will be glad if someone can help to find a better way to handle this problem
- π©πͺGermany ro-no-lo
Hi,
thanks for your feedback. I do know that this solution is not optimal. As written in the project description, it was developed with the suggestion of one of the JSON:API core maintainers in mind. Feel free to find a better way.
- π©πͺGermany ro-no-lo
Oh I see that you already did the work, but to be honest I am not *fit* enough to check if your solution will work in all circumstances. I hope the community can help here.
- πΊπ¦Ukraine _tarik_ Lutsk
I have rechecked my code here, so probably the best place for all these changes is the 2.x version of the module. The code from this merge request makes module logic too different to use in 1.x version.
I will create a new development branch and put an updated code version there. -
_tarik_ β
committed b75729f9 on 2.x
Issue #3374517: Overrided jsonapi services and controller, removed event...
-
_tarik_ β
committed b75729f9 on 2.x
- Status changed to Fixed
about 1 year ago 10:31pm 28 March 2024 - πΊπ¦Ukraine _tarik_ Lutsk
The fixes from this issue were merged into the new 2.x dev version of the module
- Status changed to Fixed
about 1 year ago 10:32pm 28 March 2024