- Issue created by @danflanagan8
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:39pm 13 July 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
Here's a patch that seems to work and has a reasonable amount of test coverage. I'm not confident there aren't bugs or security concerns lurking in here though.
In my manual testing I was able to upload an xml file that zipped to 25MB and extracted into a 500MB file. The system has a max upload of 100MB. Unfortunately, memory was getting exhausted while trying to serve the contents of the file from the HPT controller. That was resolved by refactoring the controller a bit. But it may be that some files (1GB?) are way too big for even that refactored approach.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - πΊπΈUnited States danflanagan8 St. Louis, US
Ah, the patch won't apply here because it has some zip files included for use in the tests.
The tests pass locally. And if committed, there won't be any trouble running tests on d.o. I had this problem with the crossword module a few times.
- πΊπΈUnited States jerdavis Minneapolis, MN
danflanagan8 β credited jerdavis β .
-
danflanagan8 β
committed 98354bc1 on 1.0.x
Issue #3374405 by danflanagan8, jerdavis: Allow upload of zipped...
-
danflanagan8 β
committed 98354bc1 on 1.0.x
- Status changed to Fixed
over 1 year ago 2:52pm 14 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.