- Issue created by @brianperry
To @jayhuskins point here: https://www.drupal.org/project/api_client/issues/3365506#comment-15098435 β
how can we implement this with support for localization right away?
Would that part be handled by the consumer of this library by passing in the locale to each request?
Should we require a default language like DrupalState did?
Or is the localization better handled in the JsonAPIClient instead of this base class?
- Status changed to Needs work
over 1 year ago 2:33pm 17 August 2023 - πΊπΈUnited States brianperry
This is mostly addressed by our initial project scaffolding, but I think likely needs more complete tests and possibly improved documentation.
- Assigned to brianperry
- @brianperry opened merge request.
- πΊπΈUnited States brianperry
Opened a draft MR with additional test coverage. Still need to take a quick look to see if anything else needs to be documented.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:50pm 27 August 2023 - Status changed to RTBC
over 1 year ago 4:37pm 29 August 2023 - Status changed to Fixed
over 1 year ago 8:52pm 30 August 2023 - πΊπΈUnited States brianperry
Merged. Marking as fixed. Not sure what the deal is with the merge train failing here. Will have to keep an eye on that.
Automatically closed - issue fixed for 2 weeks with no activity.