When this module is combined with the Condition Field module to add the Block Scheduler as a visibility condition to custom blocks, the following exception is thrown:
InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of core/lib/Drupal/Component/Datetime/DateTimePlus.php).
This seems to happen because the Block Schedule module stores the 'Expiry' condition as a 'DrupalDateTime' object instead of a 'int' timestamp. This is the stored data structure in the database:
a:1:{s:6:"expiry";a:3:{s:5:"start";O:35:"Drupal\Core\Datetime\DrupalDateTime":11:{s:25:"*formatTranslationCache";N;s:15:"*inputTimeRaw";s:0:"";s:20:"*inputTimeAdjusted";s:0:"";s:19:"*inputTimeZoneRaw";s:0:"";s:24:"*inputTimeZoneAdjusted";s:0:"";s:17:"*inputFormatRaw";s:0:"";s:22:"*inputFormatAdjusted";s:0:"";s:11:"*langcode";s:2:"en";s:9:"*errors";a:0:{}s:17:"*dateTimeObject";O:8:"DateTime":3:{s:4:"date";s:26:"2023-07-10 12:30:00.000000";s:13:"timezone_type";i:3;s:8:"timezone";s:16:"America/New_York";}s:20:"*stringTranslation";N;}s:3:"end";O:35:"Drupal\Core\Datetime\DrupalDateTime":11:{s:25:"*formatTranslationCache";N;s:15:"*inputTimeRaw";s:0:"";s:20:"*inputTimeAdjusted";s:0:"";s:19:"*inputTimeZoneRaw";s:0:"";s:24:"*inputTimeZoneAdjusted";s:0:"";s:17:"*inputFormatRaw";s:0:"";s:22:"*inputFormatAdjusted";s:0:"";s:11:"*langcode";s:2:"en";s:9:"*errors";a:0:{}s:17:"*dateTimeObject";O:8:"DateTime":3:{s:4:"date";s:26:"2023-07-11 12:30:00.000000";s:13:"timezone_type";i:3;s:8:"timezone";s:16:"America/New_York";}s:20:"*stringTranslation";N;}s:6:"negate";s:1:"0";}}
Catch the InvalidArgumentException on the 'buildConfigurationForm' method of the 'Expiry' class and directly return the stored object in case it already is a 'DrupalDateTime' instance.
Active
2.0
Code
Attached to this comment you will find a patch in the case you want to combine together these two awesome modules.
I attached an updated version of the patch that also manages the issues caused for the same reason on the 'evaluate' and 'getCacheMaxAge' methods of the Expiry class.