\Drupal calls should be avoided in classes, use dependency injection instead

FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/modules/crossword_colors/src/Form/CrosswordColorsConfigForm.php ---------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------- 77 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 81 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/modules/crossword_image/src/Form/CrosswordImageRegenerateForm.php ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------ FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/modules/crossword_contest/src/Controller/CrosswordContestController.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------ 37 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 40 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 44 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 64 | WARNING | Media::load calls should be avoided in classes, use dependency injection instead 98 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 100 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------ FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/src/CrosswordFileParserPluginBase.php ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 43 | WARNING | File::load calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------ FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/tests/modules/crossword_pseudofields_tests/src/Controller/CrosswordTestsController.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 29 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead 32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 34 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/crossword/tests/modules/crossword_tests/src/Controller/CrosswordTestsController.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINES -------------------------------------------------------------------------------------------------------------------------------- 30 | WARNING | [ ] Node::load calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @roshni27
Status changed to Needs work over 1 year ago6:03am 15 July 2023
Comment over 1 year ago →
🇮🇳India roshni27
Issue was unassigned.
Status changed to Needs review over 1 year ago6:55am 15 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
9 pass, 47 fail
Comment over 1 year ago →
🇮🇳India roshni27
Please the review patch.
Status changed to Closed: won't fix over 1 year ago2:51am 16 July 2023
Comment over 1 year ago →
🇺🇸United States danflanagan8 St. Louis, US
Dependency injection only matters for unit tests and I'm not planning on adding any unit tests for any of the classes here.

There are other issues in the queue if you're truly interested in helping the project.

\Drupal calls should be avoided in classes, use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities