Contrib.social

Add dependency to core/drupal and core/jquery

Open on Drupal.org →
Created on 10 July 2023, over 1 year ago
Updated 12 July 2023, over 1 year ago

Problem/Motivation

Looks like jQuery and Drupal are not explicitly noted as JS dependencies, so this causes errors when the libraries aren't present on the page.

Steps to reproduce

  1. Visit the site as an unauthenticated user, or where core/drupal and core/jquery are not already included as a library.
  2. Notice you get either "jQuery" or "Drupal" as undefined in the JS console

Proposed resolution

Explicitly add core/drupal and core/jquery as dependencies to both the admin_dialogs.selector and admin_dialogs.spinner libraries.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States Nuuou Lincoln, NE

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024