Remove deprecated module_load_include usage

I see. It got deprecated in Drupal 9.4.0 and it is removed from Drupal 11.0.0.

So the function still exists in Drupal 10, so that's why it wasn't catched by tests, I think.

When we remove the usage of module_load_include() we also need change "core_version_requirement" in xmlrpc.info.yml and xmlrpc_example.info.yml to:

core_version_requirement: ^9.4 || ^10

Suggested patch.

Good catch. Now that D8 is EOL we can remove it.

1. +++ b/tests/src/Functional/XmlRpcBasicTest.php
   @@ -88,7 +88,7 @@ class XmlRpcBasicTest extends XmlRpcTestBase {
   +    $this->mh->loadInclude('xmlrpc', 'inc');
   
   +++ b/tests/src/Functional/XmlRpcMessagesTest.php
   @@ -90,7 +90,7 @@ class XmlRpcMessagesTest extends XmlRpcTestBase {
   +    $this->mh->loadInclude('xmlrpc', 'inc');
   
   +++ b/tests/src/Functional/XmlRpcTestBase.php
   @@ -16,13 +17,25 @@ abstract class XmlRpcTestBase extends BrowserTestBase {
   +  protected ModuleHandlerInterface $mh;
   ...
   +    $this->mh = $this->container->get('module_handler');
   

   Instead of calling the variable 'mh', I would call it 'moduleHandler'. That's more descriptive.

2. +++ b/tests/src/Functional/XmlRpcTestBase.php
   @@ -16,13 +17,25 @@ abstract class XmlRpcTestBase extends BrowserTestBase {
   +  public function setUp(): void {
   

   Missing docblock.

I'm not sure what "TODO: Change the autogenerated stub" means.

"Instead of calling the variable 'mh', I would call it 'moduleHandle": I've been doing too much Go, I guess ;-)

"stub" : Forgot to remove it. It's added automatically by phpstorm when creating a method on a class where it exists on the parent.

Now only xmlrpc_example.info.yml needs to have the core_version_requirement changed as well.

Shouldn't the package for xmlrpc_example be xmlrpc ? The current "example modules" seems related to its previous life in the examples project.

I don't know what the package should be. But the package of the xmlrpc module is "Web services", so changing the package of xmlrpc_example to "xmlrpc" doesn't improve things I think.

Anyway, it looks to be out of scope for this issue.

OTOH, it's completely unrelated.

Grmmbll. Bad patch.

So, @MegaChriz, is it RTBC ?

Three months later, assuming it's good. Tests pass, static analysis is not worse, so merged to current HEAD, thanks for the reviews.

Automatically closed - issue fixed for 2 weeks with no activity.