- Issue created by @jonloh
- Status changed to Needs work
almost 2 years ago 11:36am 7 July 2023 - 🇩🇪Germany mkalkbrenner 🇩🇪
Thanks a lot for this contribution. I will add it.
But the stopwords seem wrong to me. Stopwords aren't the right choice to remove single characters or numbers, for eample a number like "57" is not touched. These should be removed within a Char Filter, see https://solr.apache.org/guide/7_5/charfilterfactories.htmlThe file name "_7.0.0" doesn't match the minimum required Solr version 7.5.0.
And we should add test coverage by editing https://git.drupalcode.org/project/search_api_solr/-/blob/4.x/tests/src/...
We should provide an update hook to install the config in existing sites.
- 🇲🇾Malaysia jonloh
Thanks @mkalkbrenner! I've created a patch based on the feedbacks.
Also, I've changed the stopwords to this list instead: https://gist.githubusercontent.com/spikeekips/40eea22ef4a89f629abd87eed5...
For the hook_update, hopefully I did it right. Kindly advise if there's other better way to do this ;)
- Status changed to Needs review
over 1 year ago 7:55am 3 August 2023 - last update
over 1 year ago 31 pass -
mkalkbrenner →
committed 0fb1999f on 4.x
Issue #3373051 by jonloh, mkalkbrenner: Optional schema for Korean...
-
mkalkbrenner →
committed 0fb1999f on 4.x
-
mkalkbrenner →
committed bb07c571 on 4.x
Issue #3373051 by jonloh, mkalkbrenner: Optional schema for Korean...
-
mkalkbrenner →
committed bb07c571 on 4.x
- Status changed to Fixed
over 1 year ago 11:47am 3 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.