\Drupal calls should be avoided in classes, use dependency injection instead

Open on Drupal.org →

Created on 6 July 2023, 12 months ago

Updated 10 February 2024, 5 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/mosparo_integration/src/Service/MosparoService.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
116 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

FILE: ...ion/modules/mosparo_contact/src/Plugin/Field/FieldWidget/MosparoWidget.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
33 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
34 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

Time: 372ms; Memory: 12MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig mosparo_integration/

Remaining tasks

Patch review

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Sign in to follow issues

Comments & Activities

Issue created by @urvashi_vora
Assigned to zepich
Comment 12 months ago →
🇨🇭Switzerland zepich
@zepich opened merge request.
Comment 12 months ago →
System Message

zepich → committed 09d30b6f on 1.0.x
Issue #3372740: \Drupal calls should be avoided in classes, use...
Comment 12 months ago →
🇨🇭Switzerland zepich
Hi @urvashi_vora

Thank you very much for your issue and the patch.

I've reviewed it and adjusted it. In my eyes, we cannot replace the \Drupal call in the MosparoWidget because it uses the constructor method from WidgetBase which is not able to accept Dependency Injection (https://git.drupalcode.org/project/mosparo_integration/-/blob/1.0.x/modu...).

I'm open to suggestions if you know how we could solve that. We have the same problem in the other module (https://git.drupalcode.org/project/mosparo_integration/-/blob/1.0.x/modu...) which the CodeSniffer didn't found.

Thank you very much, and have a nice day!

Kind regards,

zepich
Status changed to Fixed 5 months ago3:36pm 27 January 2024
Comment 5 months ago →
🇨🇭Switzerland zepich
I fixed one \Drupal usage. The other uses are not fixable in my view.
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024