Contrib.social

JS errors: Icons don't load after 8.x-2.26

Open on Drupal.org →
Created on 5 July 2023, over 1 year ago
Updated 6 July 2023, over 1 year ago

Problem/Motivation

After upgrading to 8.x-2.26, none of my FA icons load.

Browser console errors:

fontawesome.js:1 Failed to load resource: the server responded with a status of 403 ()
sharp-light.js:1 Failed to load resource: the server responded with a status of 403 ()
sharp-regular.js:1 Failed to load resource: the server responded with a status of 403 ()
sharp-solid.js:1 Failed to load resource: the server responded with a status of 403 ()
custom-icons.js:1 Failed to load resource: the server responded with a status of 403 ()

Steps to reproduce

I use Font Awesome Pro, and I'm using a Kit with icons delivered via CDN.

I tried adding "web/modules/contrib/webform/composer.libraries.json" to the merge-plugin section of my composer.json and verified that the dependency was installed, but that didn't fix the issue. Downgrading to 8.x-2.25 fixes the issue.

I verified that the Font Awesome module settings are still using the correct Kit URL, (kit.fontawesome.com/REDACTED.js).

By looking through all the code changed in the latest version, I figured out that these settings were added:

use_sharpregular_file: true
use_sharplight_file: true
use_sharpsolid_file: true
use_custom_file: true

They default to true. All of my other Partial file settings were false. Setting the new ones to false fixes the issue.

Proposed resolution

Maybe there could be an improvement made so that Partial File Configuration is not used if a CDN is used.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: works as designed

Version

2.0

Component

Code

Created by

solideogloria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024