Contrib.social

Smart Date - Recurring dates still cause duplicate instances in iCal

Open on Drupal.org →
Created on 5 July 2023, over 1 year ago
Updated 7 July 2023, over 1 year ago

When using a recurring date from the Smart date module, you may still get duplicate event instances as time goes on, because multiple events are created (one for each recurring instance), with the recurring rule.

This was originally fixed in Issue #3231318 → (Commit 8b017a8d), but then the code that fixed it was reverted in Issue #3092917 (Commit 326181a0). So I'm still getting duplicates in iCal feeds involving Smart dates with recurring rules.

I'm attaching a patch that attempts to use the current variable name for this ($processed_rules) and also do the check for already-processed smart dates with rrule.

🐛 Bug report
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

🇺🇸United States sclsweb

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sclsweb
  • Comment over 1 year ago →
    🇺🇸United States sclsweb

    The previous patch did not work for me, sadly. I'm attaching a new patch that makes $processed_rules static, as in Issue 3281261 🐛 Smart Date recurring dates cause duplicates Active .

  • Status changed to Closed: works as designed over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States sclsweb

    While continuing to troubleshoot this, I realized that the events with duplicates did not use a recurring rule, but were instead multiple smart_dates attached to a single event (i.e. the event has a smart_date field that accepts unlimited dates, including the possibility of recurring). I eliminated duplicates by turning on aggregation in the view.

    I'm not sure if that solution counts as working "as designed," but using aggregation seems to be a peculiarity of dealing with smart_dates in any views (not just views_ical).

    Hopefully the patches can help someone else who has an issue with real recurring smart_dates.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024