TypeError on node page if source image is null

Thank you. We would need an automated test here.

1. +++ b/src/Textimage.php
   @@ -349,10 +349,13 @@ class Textimage implements TextimageInterface {
   +    if ($source_image_file && !is_null($source_image_file)) {
   

   !is_null seems redundant here.

2. +++ b/src/Textimage.php
   @@ -916,4 +919,14 @@ class Textimage implements TextimageInterface {
   +  protected function createMockFile() {
   

   better name this createFallbackImageFile(), 'mock' remind me of PHPUnit tests.

3. +++ b/src/Textimage.php
   @@ -916,4 +919,14 @@ class Textimage implements TextimageInterface {
   +    $module_path = drupal_get_path('module', 'textimage');
   

   drupal_get_path is deprecated and not present in D10, https://www.drupal.org/node/2940438 → (hence we need a test...)

4. +++ b/src/Textimage.php
   @@ -916,4 +919,14 @@ class Textimage implements TextimageInterface {
   +    $file_path = $module_path . '/mock.jpg';
   

   It should be possible to configure which image file to use as a fallback.

Thank you mondrake for your review!
Here is an updated patch.

!is_null seems redundant here.
Done

better name this createFallbackImageFile(), 'mock' remind me of PHPUnit tests.
Done

drupal_get_path is deprecated and not present in D10
Done

It should be possible to configure which image file to use as a fallback.
Added the possibility to set a custom fallback image via the module settings page.\

I also added a simple test. Unfortunately had no chance to verify it.

Please check when you have a moment.

The last submitted patch, 3: 0002-absent-image-handling.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.