- Issue created by @scott_euser
- @scott_euser opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:47pm 4 July 2023 - π¬π§United Kingdom scott_euser
Also combined patch attached for #3372256 + #3372260 since these have a merge conflict in the update hook (since both require a new update hoo)
- πΊπΈUnited States aaronpinero
@scott_euser thank you for this work. I will do my best to review this today or tomorrow so as to get the module updated quickly.
- πΊπΈUnited States aaronpinero
I've reviewed the patch and it mostly looks good. There are two things that I need to address:
- there is call to the config service in the hook_cron function that can be removed since the date is going to now be stored in state.
- there needs to be accounting for the case where there is no saved state. - Status changed to Needs work
over 1 year ago 11:12pm 6 July 2023 - π¬π§United Kingdom scott_euser
Hi @aaronpinero,
Thanks for the quick review on both of these!
For no state saved, what do you think of:
- Set state to current time +1 day
- Update field description on config page to say that if not set, state will be set to current time +1 day
- Add a note to README to say that if not set, state will be set to current time +1 day
- Status changed to Needs review
over 1 year ago 9:46am 18 July 2023 - π¬π§United Kingdom scott_euser
Thanks, I have updated the MR to reflect the above. Ready for review again.
-
aaronpinero β
committed 4dabae87 on 1.0.x authored by
scott_euser β
Issue #3372260: Review Notifications 'Next Send' is stored in config yet...
-
aaronpinero β
committed 4dabae87 on 1.0.x authored by
scott_euser β
- Status changed to Fixed
over 1 year ago 5:09pm 31 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.