Skip types hook - should compare field type?

Created on 4 July 2023, over 1 year ago

Problem/Motivation

hook_multiple_field_remove_button_skip_types_alter() is described as "Modify field types for which remove button will not be added." - however the logic in line 194 of the module compares the $elementType variable, not $type. Is this intended? I think it should compare (field) $type, based on the hook description.

Proposed resolution

Attached patch compares the field type ($type) to anything listed in $skipTypes in the logic.

🐛 Bug report
Status

Needs review

Version

2.2

Component

Code

Created by

🇨🇦Canada bgilhome Victoria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024