- Issue created by @mark_fullmer
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:45pm 30 June 2023 - πΊπΈUnited States mark_fullmer Tucson
The attached patch provides the missing colons for the Outlook display. I also had to update the test logic a bit to correctly pull the $entity->label() value for the mock. Not sure when that went sideways, but the change should be pretty uncontroversial.
I tested that patch and confirmed it worked! Thank you so much!
- Status changed to RTBC
over 1 year ago 4:00pm 19 July 2023 - πΊπΈUnited States mark_fullmer Tucson
Based on the comment above, I'm setting this to RTBC.
I think this might justify a timely new beta release (
1.1.0-beta2
) that includes this change, since all MS Outlook imports are currently nonfunctional in 1.1.0-beta1. - πΊπΈUnited States mark_fullmer Tucson
Since this has been RTBC'd -- and I reviewed this again just now and feel good about it -- I'll merge it into 1.1.x-dev, noting that the only functional change is the addition of the colon; the rest is fixing test logic.
-
mark_fullmer β
committed 52c16845 on 1.1.x
Issue #3371690 by mark_fullmer, jbaum_13: [Outlook] DTSTART and DTEND...
-
mark_fullmer β
committed 52c16845 on 1.1.x
- Status changed to Fixed
over 1 year ago 7:18pm 28 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.