Contrib.social

accordion.frontend.js is unminified

Open on Drupal.org →
Created on 30 June 2023, 12 months ago
Updated 3 December 2023, 7 months ago

Hi all

I have "aggregate javascript" enabled at /admin/config/development/performance but Semrush SEO site audit complains that the file /modules/contrib/ckeditor_accordion/js/accordion.frontend.js is unminified and I can see the file in my page source.

Is it expected that accordion.frontend.js is excluded from Drupal's aggregation, and if so is it possible to minify this file?

💬 Support request
Status

Fixed

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom Juc1

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Juc1
  • Comment 12 months ago →
    🇬🇧United Kingdom Juc1

    Also it seems that the file /modules/contrib/ckeditor_accordion/js/accordion.frontend.js is loaded on every node as soon as the module is enabled ie whether or not the page has an accordion or is using ckeditor - shouldn't it only be loaded on pages that are using the ckeditor_accordion module?

  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇫🇮Finland j-vee Turku, Finland

    Fixed in 2.1.0, thanks!

  • Comment 7 months ago →
    🇺🇸United States UTCbrij

    The 2.1.0 minified version is not the same as the unminified version. Need to reminify. See attached patch.

  • Comment 6 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024