- Issue created by @phenaproxima
- Merge request !928Issue #3371212: LockFileValidator should store the lock file hash in the stage's metadata, rather than directly in state β (Open) created by phenaproxima
- last update
over 1 year ago Custom Commands Failed - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 2:55am 29 June 2023 - πΊπΈUnited States phenaproxima Massachusetts
This is internal refactoring, so it doesn't need explicit test coverage. Assigning to @tedbow for review.
- last update
over 1 year ago Custom Commands Failed - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 5:12pm 29 June 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 785 pass, 4 fail - Status changed to RTBC
over 1 year ago 5:24pm 29 June 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good!
Are there other validators or stage event subscribers where we are using state where we could now use stage metadata?
- Assigned to tedbow
- πΊπΈUnited States phenaproxima Massachusetts
I'm not sure, off the top of my head.
But, in this branch, a search of the Drupal\package_manager\Validator namespace for
->state
turns up nothing. There's one use in Automatic Updates, but it's not for stage-specific metadata. - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - Issue was unassigned.
- last update
over 1 year ago CI aborted - last update
over 1 year ago 794 pass, 2 fail - last update
over 1 year ago 794 pass, 2 fail - last update
over 1 year ago 801 pass, 1 fail - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 7:29pm 29 June 2023 - πΊπΈUnited States phenaproxima Massachusetts
The change I needed to make to fix the tests necessitate a re-review.
- last update
over 1 year ago 801 pass, 1 fail - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:47pm 29 June 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 12:41pm 30 June 2023 - last update
about 1 year ago 764 pass, 2 fail - last update
about 1 year ago 771 pass, 1 fail