- Issue created by @breaker_tom
- πΊπΈUnited States breaker_tom San Antonio
This patch removes the php 8 syntax which is incompatible with php 7.4
- πΊπΈUnited States breaker_tom San Antonio
My apologies Daniel - I have prepared a patch (my first) - and i cannot find the dialog to upload it to this issue.
- πΊπΈUnited States daniel.moberly
This patch resolves the compatibility but reverts π Compatibility with Core 10.1.* Fixed . We need a solution to address both issues
- πΊπΈUnited States breaker_tom San Antonio
PHP 7.4 and Core 10.1.* are incompatible with each other. The patch was produced to keep the site running while PHP is upgraded to version 8.
- πΊπΈUnited States daniel.moberly
The patch has to support both. Some folks have PHP 7.4 running an earlier version of Drupal, some have 10.1 and a later version of PHP. If we commit this patch to support the earlier versions, it breaks the later version. We need a solution that supports both.
- πΊπΈUnited States breaker_tom San Antonio
Patch provides backwards compatibility to PHP 7 and preserves compatibility with core 10.1.*
- πΊπΈUnited States breaker_tom San Antonio
This patch correctly supports php 7.3 and core 10.1.*
- πΊπΈUnited States daniel.moberly
I appreciate the patch. I think something like this would be cleaner
$authenticated_role ? $authenticated_role->grantPermission('access fontawesome additional settings')->save() : NULL;
- πΊπΈUnited States breaker_tom San Antonio
Indeed ... I am out for 4 days. I will role up another on Monday. Thanks again
- πΊπΈUnited States agbockus Illinois
Created a patch with the recommendation from Daniel!
-
Daniel.Moberly β
committed 753075a3 on 8.x-2.x authored by
agbockus β
Issue #3371082 by breaker_tom, agbockus: Need backwards compatibility...
-
Daniel.Moberly β
committed 753075a3 on 8.x-2.x authored by
agbockus β
- Status changed to Fixed
over 1 year ago 6:25pm 29 June 2023 - πΊπΈUnited States breaker_tom San Antonio
agbockus, thanks for the clean up. Daniel, thanks for the patience
Automatically closed - issue fixed for 2 weeks with no activity.