getPostLoginRedirection destination is ignored if destination query param is present

Created on 27 June 2023, about 1 year ago

Problem/Motivation

If another module has set the destination query parameter into the request stack, the redirect issued by getPostLoginRedirection fails, overridden by the destination.

Steps to reproduce

- Install https://www.drupal.org/project/login_destination →
- Configure a destination that redirects users to "/" after login
- Enable "Preserve the destination parameter" in the module settings (not sure whether this is required to reproduce or not)
- Do social login with ?destination parameter
- getPostLoginRedirection returns a RedirectResponse with the destination URL as expected
- The RedirectResponse is ignored when it is used, due to ?destination param in the query stack being equal to that of the destination configured in Login Destination

Proposed resolution

Set the destination param in the request stack when determining the destination redirect

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report

Status

Needs review

Version

3.1

Component

Code

Created by

🇺🇸United States mrweiner

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mrweiner
Status changed to Needs review about 1 year ago10:23pm 27 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update about 1 year ago
5 pass
Comment about 1 year ago →
🇺🇸United States mrweiner
Attaching patch to address the issue. There's a comment in the patch noting that this probably isn't the ideal place to do this, but I couldn't get it working elsewhere. Maybe somebody else can work out a better implementation.
Comment about 1 year ago →
🇺🇸United States mrweiner
Possibly related to 🐛 Login link destination URL parameter doesn't work if site installed in sub directory Active

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024