Do not allow core: 8.x in info.yml file.

Hello Maintainers,
I have provided a patch to fix this issue.
To get more information visit https://www.drupal.org/node/3070687 →
Please review it.

Thanks!

I've manually tested to install XMLRPC on a Drupal 10.1 site and that went without issues. The automated tests also pass on Drupal 10.

So I think removing the core key is not required and that there's no bug here. In certain situations the core key may not be allowed, such as when core_version_requirement is ^8.8 || ^9.

Or do you experience installation issues/exceptions? On which Drupal and PHP versions?

Hi @MegaChriz, My point here is the core key needs to be removed from info.yml files to make the module compatible with D10. If you just want to support D9 and you still want to support D8, which is EOL for a long time now, you can keep the key but then the module can't support D10 in that version.

Thanks!

@Harshita mehna
I can install the module on a D10 site without issues, so removing the core key is not required for D10 compatibility. At least in this particular case.

However, keeping the core key doesn't seem to have additional benefit either because I read on https://www.drupal.org/node/3070687 → that Drupal sites < 8.8.2 will have trouble using this project because the test module "xmlrpc_test" doesn't have either a core key or a core_version_requirement key:

Note that test modules can omit the core_version_requirement key entirely as of Drupal 8.8.2, so that they will work with any core version they are tested against. Prior to 8.8.2, the value is required for test modules and will cause site errors if it is not included.

So therefore I have merged your changes. :) I just change the category to "Task", because I believe it isn't a bug.

@MegaChriz,
Thanks :) for the review and reply.

Automatically closed - issue fixed for 2 weeks with no activity.