Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 27 June 2023, about 1 year ago
Updated 29 June 2023, 12 months ago

Problem/Motivation

37 | ERROR | [x] Concat operator must be surrounded by a single space
38 | ERROR | [x] Concat operator must be surrounded by a single space
38 | ERROR | [ ] Function strftime() has been deprecated
39 | ERROR | [ ] Function strftime() has been deprecated
65 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
98 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9_test/code/modules/contrib/health_check_url/src/Routing/RouteService.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
22 | ERROR | Missing short description in doc comment

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India yashmalviya

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @yashmalviya
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India yashmalviya

    I have resolved the above errors and warnings. Please review.

  • Comment about 1 year ago →
    🇮🇳India _pratik_ Banglore

    The above patch look good, it no phpcs error/warning found.
    Thanks

  • Comment 12 months ago →
    🇮🇳India Anjali Mehta

    Hi I reviewed patch #2, and there are still remaining issues applying the patch.
    I am adding some screenshots(before/after applying the patch) for your reference).
    Please have a look at these screenshots.

    Thank You.

  • Comment 12 months ago →
    🇮🇳India yashmalviya

    Hi @Anjali Mehta I have checked your attached screenshot and run the PHPCS command but didn't find any error or warning its looks clean. I have shared a screenshot for the same.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024