- Issue created by @slashrsm
- Status changed to Needs review
over 1 year ago 9:35am 27 June 2023 - 🇬🇧United Kingdom gMaximus
I've tested this on the dev branch.
I also had to change line 206 of the controller to
$css_minifier->addLicense($data, preg_replace('/\.min\.css$/', '.css', \Drupal::service('file_url_generator')->generateAbsoluteString($uri)));
Otherwise I was getting this error:
Error: Call to undefined function Drupal\background_image\Controller\file_create_url() in Drupal\background_image\Controller\BackgroundImageCssController->buildCss() (line 206 of \background_image\src\Controller\BackgroundImageCssController.php).
The file_create_url() method is deprecated. See this: https://www.drupal.org/node/2940031 →
Thanks for your patch. I've been stuck on this for a couple of days.
- Status changed to Fixed
about 1 year ago 1:07am 7 November 2023 - 🇦🇺Australia Nigel Cunningham Geelong
Thanks for the report.
I saw this too today and have committed the same change; it is working for me now on the dev branch. I hope to make a new release shortly. If you have any further issues, please let me know.
Thanks again!
Automatically closed - issue fixed for 2 weeks with no activity.