- Issue created by @markdorison
- @markdorison opened merge request.
- Status changed to Needs review
about 1 year ago 1:03am 27 June 2023 - First commit to issue fork.
- Status changed to Fixed
about 1 year ago 5:59pm 27 June 2023 - 🇺🇸United States adamzimmermann
Merged. Thank you for the improvements.
For this issue and another one I have had to merge the MR from GitLab. The merge button at the bottom of the issue page (this page) would fail. I'm not sure what is going on. Mark, is this related to any of the pipelines you have configured?
-
adamzimmermann →
committed 894900f9 on 1.x authored by
markdorison →
Issue #3370339 by markdorison: Explicitly declare constant visibility
-
adamzimmermann →
committed 894900f9 on 1.x authored by
markdorison →
- 🇺🇸United States markdorison
@adamzimmermann Did this occur after you had already merged a different MR. Maybe you needed to rebase this one first in the GitLab UI?
AFAIK pipelines should not be related.
- 🇺🇸United States adamzimmermann
@markdorison ah that might be it. I rebased a different issue branch and was able to use the button, so that checks out. Thanks for explaining that.
- @markdorison opened merge request.
- Status changed to Needs review
about 1 year ago 7:57pm 27 June 2023 -
adamzimmermann →
committed 219ac165 on 1.x authored by
markdorison →
Issue #3370339 by markdorison, adamzimmermann: Explicitly declare...
-
adamzimmermann →
committed 219ac165 on 1.x authored by
markdorison →
- Status changed to Fixed
about 1 year ago 8:13pm 27 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.