- Issue created by @adamzimmermann
- @adamzimmermann opened merge request.
- Status changed to Needs review
almost 2 years ago 2:48am 26 June 2023 - πΊπΈUnited States apotek
Hi @adamzimmermann! I took a look at your merge request and I believe this should solve the issue in terms of immediate resolution to the proximate bug.
I have some questions about the scope of this bug that are of a more conceptual nature and will address those elsewhere. But yes, this patch looks good and should fix the problem reported.
-
adamzimmermann β
committed 1777b47d on 1.x
Issue #3369165 by adamzimmermann, apotek: Taxonomy migrations throw...
-
adamzimmermann β
committed 1777b47d on 1.x
- Status changed to Fixed
almost 2 years ago 9:36pm 27 June 2023 - First commit to issue fork.
- @markdorison opened merge request.
- Status changed to Needs review
almost 2 years ago 11:45pm 27 June 2023 - πΊπΈUnited States markdorison
I created a new MR with an updated assertion to replace the one that was removed in MR3. Does that work?
-
adamzimmermann β
committed 6db73ffa on 1.x authored by
markdorison β
Issue #3369165 by adamzimmermann, markdorison, apotek: Taxonomy...
-
adamzimmermann β
committed 6db73ffa on 1.x authored by
markdorison β
- Status changed to Fixed
almost 2 years ago 2:34pm 28 June 2023 - πΊπΈUnited States apotek
Using latest dev release, the error is still being thrown on all taxonomy types:
[error] Invalid Orange DAM system identifier "Air Line Pilots Association". (/var/www/html/docroot/modules/contrib/orange_dam/src/OrangeDamContent.php:95)
[error] Invalid Orange DAM system identifier "Alabama. Army National Guard". (/var/www/html/docroot/modules/contrib/orange_dam/src/OrangeDamContent.php:95)So the patch above did not manage to fix the issue.
- Status changed to Active
almost 2 years ago 7:43pm 3 July 2023 - @apotek opened merge request.
- Assigned to apotek
- Status changed to Needs review
almost 2 years ago 5:44am 4 July 2023 - Status changed to RTBC
almost 2 years ago 3:46pm 4 July 2023 - πΊπΈUnited States apotek
Reviewed/Approved by @adamzimmerman. Merging.
-
apotek β
committed 3b3ad255 on 1.x
Fix the test for whether to check for duplicates On a given row in...
-
apotek β
committed 3b3ad255 on 1.x
- Assigned to adamzimmermann
- Status changed to Fixed
almost 2 years ago 4:15pm 4 July 2023 - Status changed to Fixed
over 1 year ago 5:27pm 7 July 2023