- Issue created by @gngn
- Status changed to Needs review
over 1 year ago 5:18pm 23 June 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇩🇪Germany gngn
Patch like proposed above.
I did not test with exceptional day or seasons.
- Status changed to Needs work
over 1 year ago 7:51am 28 June 2023 - 🇳🇱Netherlands johnv
Thanks,
patch needs some rework.
It is possible that endhours or starthours are empty (value NULL), in that case the sorting is not executd, due to the isset(). - 🇩🇪Germany gngn
In #3 johnv states:
It is possible that endhours or starthours are empty (value NULL), in that case the sorting is not executd, due to the isset()
If endhours or starthours are empty (value NULL) we cannot compare the values - so we cannot sort by 'em.
Patch #2 than falls back to the behaviour without the patch - i.e. same day means "equal" (return 0
).We could implement something like not null value is greater than NULL or something similar.
Or what am I not getting?
- Status changed to Fixed
about 1 year ago 9:26am 24 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 11:35am 26 September 2023 - 🇳🇱Netherlands johnv
Please check #3416914-14: Sort order of same day slots incorrect in row (widget) and column (formatter) → .
That patch basically reverts this one. The hours of one day should be unsorted. It is the user's responsibility.
The change will be in current dev version or in version 8.x-1.13