- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Issue created by @bgilhome
phpcs testing for PHP 8 shows the following warning for `src/Form/BlockSettingsForm.php`:
`Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$array" was used, and possibly changed (by reference), on line 155.`
Run e.g. `./vendor/bin/phpcs -p web/modules/contrib/gutenberg --extensions=php,module,theme,install,profile --standard=vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.1`
Attached patch moves the func_get_args() call first in the arrayFlatten() method.
Needs review
2.0
Code