Drush build test symlinks Drush, and does not install any of its dependencies

this issue is major because it blocks 📌 For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits Fixed

Pushed commit that fixed the test locally. will see if drupalci is fixed

Looks good if tests pass.

Kicking back for failure on 10.0.x. :(

Ok think the build tests will pass now on both branches

    // Do not run development Composer plugin.
    $this->runComposer("composer config allow-plugins.dealerdirect/phpcodesniffer-composer-installer false", $template_dir);

Why?

        if (isset($package_info['require'])) {
          unset(
            $package_info['require']['symfony/polyfill-php72'],
            $package_info['require']['symfony/polyfill-php73'],
            $package_info['require']['symfony/polyfill-php74'],
            $package_info['require']['symfony/polyfill-php80'],
            $package_info['require']['symfony/polyfill-php81'],
          );
          $packages[$name][$version]['require'] = $package_info['require'];
        }

Why? These are not dependencies of https://github.com/drush-ops/drush/blob/12.x/composer.json?

I cannot find the answers in the code nor in this issue 😅

To answer your questions:

1. Because, unless we disable this, install fails because it (the plugin) tries to run an executable before it's available. At least, that's what I understand from discussing with @tedbow, who traced into it. Probably a bug in the plugin itself. For our purposes, we don't need that plugin in any event, so it's okay to work around it.
2. Those packages are dependencies of some packages, but they are (somehow - don't ask me why) not installed on PHP versions that don't need them (i.e., you don't need a PHP 7.2 polyfill on PHP 8). Since Drupal 10 requires PHP 8.1, those polyfills are not actually present in the local codebase and therefore unable to be installed, so we just make sure no package depends on them, since that would break Composer's ability to build the code base successfully. I remember having to do similar stuff in some earlier iterations of the build tests.

Thanks!

So I was hoping that what's written in #14 would be shipped with the code in the form of comments, because otherwise it'll be really hard to track down once this gets into core 😅 (i.e. to answer )

I am just trying to make things simpler for our future selves!

@Wim Leers thanks for asking these questions. Sounds at least like we need follow-up to at least add some code comments. Likely we would get these questions on our core review

@phenaproxima thanks for adding comments in the new MR. I think they looks good

Automatically closed - issue fixed for 2 weeks with no activity.