- Issue created by @ambient.impact
- @ambientimpact opened merge request.
- 🇨🇦Canada ambient.impact Toronto
Hmm, actually, this might not be as clear a fix because this isn't fixed like I thought it would be. Looks like Drupal 10.1 deprecated the js-cookie library → , so maybe this module should explicitly add this independently of core, i.e. via your
package.json
? - 🇨🇦Canada ambient.impact Toronto
Alright, I've confirmed that in our case, adding the
js-cookie
library to our theme via Yarn and defining it as our own library without using the deprecatedcore/js-cookie
seems to work perfectly on 10.1-rc1 with JavaScript aggregation enabled. See https://github.com/neurocracy/drupal-omnipedia-site-theme/commit/9c1738d... - Status changed to Needs review
about 1 year ago 1:00pm 15 October 2023 - 🇳🇴Norway svenryen
@Ambient.Impact, could you provide steps to reproduce?
I'm at 10.1.5 with JS and CSS aggregation enabled, and I don't get this error.
- Status changed to Postponed: needs info
about 1 year ago 12:56pm 22 October 2023 - Status changed to Closed: cannot reproduce
about 1 year ago 2:51pm 23 October 2023 - 🇨🇦Canada ambient.impact Toronto
I'm not sure if the issue was even in this module so we can close it for now and I'll re-open if I come across it again. Thanks!