PHP 8.0 incompatibility: Trying to access array offset on value of type null in geocoder_widget_parse_addressfield()

Patch of the merge request in #2.

Thanks for reporting this.

The patch/MR fix is not working, because the variable $areas being checked in the if condition is defined only later. So this updated condition will always evaluate to FALSE:

-  if (!empty($field_item['country']) && !empty($field_item['administrative_area'])) {
+  if (!empty($field_item['country']) && !empty($field_item['administrative_area']) && !empty($areas[$field_item['administrative_area']])) {
     module_load_include('inc', 'addressfield', 'addressfield.administrative_areas');
     $areas = addressfield_get_administrative_areas($field_item['country']);

As per documentation of addressfield_get_administrative_areas(), it can return a NULL:

/**
* Returns the predefined administrative areas.
*
* @param $country_code
* The country code for which administrative areas should be returned.
*
* @return
* An array of predefined administrative areas for the given country code, or
* NULL if not found.
*/
function addressfield_get_administrative_areas($country_code) {

Fixed this by adding a is_null check on $areas, see the commit. Thanks!

poker10 → closed merge request !28

Automatically closed - issue fixed for 2 weeks with no activity.