- Issue created by @ksenzee
- Status changed to Needs review
over 1 year ago 7:30am 16 June 2023 - last update
over 1 year ago 3 pass -
mark_fullmer β
committed 21d3f3bd on 8.x-1.x authored by
ksenzee β
Issue #3367183 by ksenzee: makeElementAccessible() removes links
-
mark_fullmer β
committed 21d3f3bd on 8.x-1.x authored by
ksenzee β
- Status changed to Fixed
over 1 year ago 12:00pm 16 June 2023 - πΊπΈUnited States mark_fullmer Tucson
Thanks for reporting this. I agree with your analysis, and agree that this wouldn't introduce any security risks. I assume it was an oversight in the original code.
Committed and marked as fixed!
- πΊπΈUnited States ksenzee Washington state
Fastest commit in the west :D thank you!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Active
3 months ago 7:58pm 27 September 2024 - πΊπΈUnited States mark_fullmer Tucson
Re-opening. This issue was accidentally re-introduced in the 2.x branch.
- πΊπΈUnited States mark_fullmer Tucson
On second thought, the methodology in 2.x is now correct: it adds aria-hidden=true to the *replacement* labels, while leaving the original
th
elements available for screen readers -- the most accessible option, since the table semantics are preserved. For visitors navigating visually on mobile, the table headers have CSS that makes them visually invisible (while still screen-reader accessible) and shows the *replacement* labels (that have the aria-hidden=true for screen readers, avoiding duplication). -
mark_fullmer β
committed 8844dec1 on 2.x
Issue #3367183 by mark_fullmer, ksenzee: makeElementAccessible() removes...
-
mark_fullmer β
committed 8844dec1 on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.