- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:21pm 15 June 2023 - last update
almost 2 years ago 19 pass - Status changed to Closed: duplicate
almost 2 years ago 5:03pm 15 June 2023 - 🇮🇩Indonesia gausarts
Please always check out for dups beforehand to avoid inconvenience.
Drupal kindly gives us a searchbox and already warned us to use it. That would be very much helpful for us both if you consider using it.
I am fine with support dups, but honestly not a big fan of patch dups :)
I will write it here a bit more comprehensive to point other dups to for these particular issues.
- Regarding version. You didn't read the warnings there. You removed what the tools told you without even removing the leftover warnings. The warnings said we should remove it. It agreed with you. But only after the mentioned problems resolved. You just need to understand the written problems there.
- Regarding slick_slick(). IMHO,
slick()
is a ridiculously unique function name. It can't be more ridiculous likeslick_slick()
. That rule is certainly a must for non-unique or meaningful or potentially conflicting or reserved names likegoto, list, filter
, or more here https://www.php.net/manual/en/reserved.keywords.php which might conflict with upstream potential function names. Rest assured, we can always change it later when PHP authorities mistakenly take over that stupid name, but certainly not now, or in the near future. I am positively sure they are great mind people who would consider taking function names very seriously, not ridiculously. Also did you consider about the entire ecosystem integrity for this change, including my custom modules?
A fine line between paranoia and insanity is common sense. We should consider using it sometimes.
Please also close your dup issues.
Thank you for kind considerations.