- Issue created by @paulrad
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - @paulrad opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:29pm 15 June 2023 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Status changed to Fixed
almost 2 years ago 1:53pm 15 June 2023 - 🇳🇱Netherlands johnv
That seems reasonable.
Committed your proposal.From your point of view, is this a regression error? Or a feature request?
It would be nice if the linek shows automatically, when user enters some data in a time slot.OTOH, that might be a confusing UX.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - 🇺🇦Ukraine paulrad
johnv, I'm not sure cause this logic was explicitly predefined and maybe had some purpose I didn't meet in my project.
I also thought that the button label could be changed for something like "Remove" if the value is saved in the field and "Clear" for newly added/edited data.
- 🇳🇱Netherlands johnv
In the past, I did change the caption, using as many Drupal core translations.
So it could be that I change 'Clear' to 'Remove'.
Indeed, 'Clear' better covers the functionality. Automatically closed - issue fixed for 2 weeks with no activity.