- Issue created by @AndyF
- last update
about 1 year ago 31 pass, 4 fail - @andyf opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:31pm 13 June 2023 - π¬π§United Kingdom AndyF
I've made a first attempt at that. It could be cleaned up a little and the testing increased, but I was hoping to get some initial feedback on the overall approach before going further with the polish...?
Thanks!
- last update
about 1 year ago 31 pass, 4 fail - last update
about 1 year ago 35 pass - π¬π§United Kingdom AndyF
Attaching a patch for composer from
8eab48f6e2443ecfd899a61e93f26c700940c2b1
, thanks! - Status changed to Needs work
about 1 year ago 1:04pm 14 June 2023 - πͺπΈSpain marcoscano Barcelona, Spain
Thanks for contributing!
I agree this would be a nice addition to the usage page, and I'm onboard with adding this to the module. I left a comment on the code about improving wording on the UI text, but apart from that I don't see big red flags.
It would be important to add test coverage to all new scenarios we are adding, combinations of languages, pending/past revisions, etc.
Thanks!
- last update
about 1 year ago 31 pass, 4 fail - π¬π§United Kingdom AndyF
Thanks so much, glad to hear this could make its way into the module! Agree that tests are needed, and I'll get on that over the next few days.
- π¬π§United Kingdom AndyF
Btw just in case you hadn't seen, but there seems to be a layout-builder related failure with D10.1 which I think is entirely unrelated to this MR, see eg https://www.drupal.org/pift-ci-job/2692049 β ... had me well confused yesterday wondering what I'd broken ;)
- last update
about 1 year ago 35 pass - π¬π§United Kingdom AndyF
Attaching a patch for composer from 6bfb4d583fbe3684cd73abb73ea995a414ee1b80, thanks!