- Issue created by @AndyF
- Merge request !53Issue #3366527: Differentiate pending/old revisions and default translations β (Merged) created by AndyF
- last update
over 1 year ago 31 pass, 4 fail - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:31pm 13 June 2023 - π¬π§United Kingdom AndyF
I've made a first attempt at that. It could be cleaned up a little and the testing increased, but I was hoping to get some initial feedback on the overall approach before going further with the polish...?
Thanks!
- last update
over 1 year ago 31 pass, 4 fail - last update
over 1 year ago 35 pass - π¬π§United Kingdom AndyF
Attaching a patch for composer from
8eab48f6e2443ecfd899a61e93f26c700940c2b1
, thanks! - Status changed to Needs work
over 1 year ago 1:04pm 14 June 2023 - πͺπΈSpain marcoscano Barcelona, Spain
Thanks for contributing!
I agree this would be a nice addition to the usage page, and I'm onboard with adding this to the module. I left a comment on the code about improving wording on the UI text, but apart from that I don't see big red flags.
It would be important to add test coverage to all new scenarios we are adding, combinations of languages, pending/past revisions, etc.
Thanks!
- last update
over 1 year ago 31 pass, 4 fail - π¬π§United Kingdom AndyF
Thanks so much, glad to hear this could make its way into the module! Agree that tests are needed, and I'll get on that over the next few days.
- π¬π§United Kingdom AndyF
Btw just in case you hadn't seen, but there seems to be a layout-builder related failure with D10.1 which I think is entirely unrelated to this MR, see eg https://www.drupal.org/pift-ci-job/2692049 β ... had me well confused yesterday wondering what I'd broken ;)
- last update
over 1 year ago 35 pass - π¬π§United Kingdom AndyF
Attaching a patch for composer from 6bfb4d583fbe3684cd73abb73ea995a414ee1b80, thanks!
- First commit to issue fork.
- π¬π§United Kingdom alexpott πͺπΊπ
We will need to add a test for and fix π Usages that have no revisions show up as "Translations or Previous Revisions" Fixed as that one went in without a test and caused a conflict when I rebased the MR.
- π¬π§United Kingdom alexpott πͺπΊπ
Good news is the manual testing shows that this issue was a fix for π Usages that have no revisions show up as "Translations or Previous Revisions" Fixed too! Now to add some automated test coverage.
-
marcoscano β
committed 2de30642 on 8.x-2.x authored by
andyf β
Issue #3366527 by andyf, alexpott, marcoscano: Differentiate pending/old...
-
marcoscano β
committed 2de30642 on 8.x-2.x authored by
andyf β
- πͺπΈSpain marcoscano Barcelona, Spain
Looks good to me, thanks both for contributing!
- πͺπΈSpain marcoscano Barcelona, Spain
Tagged a new release with this π
- π¬π§United Kingdom AndyF
Agree that tests are needed, and I'll get on that over the next few days.
π
Thanks @alexpott!
Automatically closed - issue fixed for 2 weeks with no activity.