array_flip fails on NULL

TypeError: array_flip(): Argument #1 ($array) must be of type array, null given in /var/www/fleet.samtrans.se-web/web/modules/contrib/content_access/content_access.module on line 175 #0 /var/www/fleet.samtrans.se-web/web/modules/contrib/content_access/content_access.module(175): array_flip(NULL)

Comments & Activities

Issue created by @arne_hortell

Comment almost 2 years ago →

🇸🇪Sweden arne_hortell

My patch

diff --git a/content_access.module b/content_access.module
index e507418..9c16db8 100644
--- a/content_access.module
+++ b/content_access.module
@@ -172,7 +172,7 @@ function content_access_entity_insert(EntityInterface $entity) {
   $config = \Drupal::configFactory()->getEditable('content_access.settings');
 
   if ($entity instanceof RoleInterface) {
-    $roles_gids = array_flip($config->get('content_access_roles_gids'));
+    $roles_gids = array_flip((array)$config->get('content_access_roles_gids'));
     $roles_gids[] = $entity->id();
     $config->set('content_access_roles_gids', array_flip($roles_gids));
     $config->save();

Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
9 pass
Comment almost 2 years ago →
System Message

arne_hortell → authored 9f18995d on 2.0.x
Issue #3366001 by arne_hortell: Argument 1 to array_flip must be array
Status changed to Fixed almost 2 years ago11:15am 10 June 2023
Comment almost 2 years ago →
🇳🇴Norway gisle Norway
Looks good.

This has been committed to the latest snapshot of the 2.0.x-dev branch.
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities