- Issue created by @scott_earnest
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
almost 2 years ago Not currently mergeable. - @scott_earnest opened merge request.
- last update
almost 2 years ago 98 pass - 🇺🇸United States scott_earnest
Hi there-
Seeing the issue on:
Drupal 9.5.8
Entity Embed 8.x-1.3Thanks Dave!
- 🇺🇸United States scott_earnest
Not sure if i did that MR right, but easy fix:
entity_embed/src/Plugin/CKEditorPlugin/DrupalEntity.php
- protected function getButton(EmbedButtonInterface $embed_button) { + protected function getButton(EmbedButtonInterface $embed_button): array { - Status changed to Closed: duplicate
almost 2 years ago 7:09pm 8 June 2023 - 🇺🇸United States dave reid Nebraska USA
This is not an issue with the latest stable release of Embed module, you must be using the dev branch. It will be fixed shortly in Embed with 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC
- Status changed to Active
almost 2 years ago 7:11pm 8 June 2023 - 🇺🇸United States dave reid Nebraska USA
Actually I will just purpose for this.
- Status changed to Needs review
almost 2 years ago 7:12pm 8 June 2023 - last update
almost 2 years ago 19 pass - last update
almost 2 years ago 19 pass - last update
almost 2 years ago 19 pass - last update
almost 2 years ago 19 pass -
Dave Reid →
committed 41b782c7 on 8.x-1.x
Issue #3365508 by scott_earnest, Dave Reid: Removed return typehinting...
-
Dave Reid →
committed 41b782c7 on 8.x-1.x
- Status changed to Fixed
almost 2 years ago 7:19pm 8 June 2023 - 🇺🇸United States scott_earnest
Thank you for the quick turnaround @dave-reid and much apologies, turns out we were running the dev version of embed:
Drupal: 9.5.8
Embed: dev-1.x
Entity Embed: 8.x-1.3 Automatically closed - issue fixed for 2 weeks with no activity.