[DrupalCon] Automatic Updates alpha test result

Created on 7 June 2023, over 1 year ago
Updated 12 June 2023, over 1 year ago

Thanks for testing Automatic Updates! Please tell us in detail about your experience with the Updates and any problems you encountered. To help you, you can use the prompts below as guidance.

What was your goal? For example, what versions of Drupal core were you trying to update from and to?

10.0.0 to 10.0.9

If you had a problem, what were the steps you took, starting from when you added the Automatic Updates module to your Drupal project (see testing instructions β†’ )? Include anything that seems relevant, including commands you ran, links you clicked on, output logs, relevant config files, screenshots, screen recordings, etc.

No problems

What was your environment like?
Please answer as many of the following questions as you can.

Was this a local development environment, or a remote server?:

local development environment

Are you using Lando, DDEV, or another Docker-based environment?:

Lando 3.11

What operating system were you using?

Ubuntu 20.04.5 LTS

What web server are you using?

Apache 2.4

What PHP version are you using (see https://www.drupal.org/i/3275810#confirm-php-version β†’ )?

PHP 8.1.18

What version of Composer are you using (see https://www.drupal.org/i/3275810#confirm-composer-version β†’ )?

Composer 2.5.7

Did you accomplish your goal? Were the instructions clear? Did you observe any bugs or errors, or other issues? Did you need to do any workarounds?

Yes. No bugs.
A message did appear prior to update, which seemed a normal alert of database updates ahead:

Warning message
Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might affect the eligibility for automatic updates.

    Possible database updates have been detected in the following extensions.
        System
        User

Problem with these instructions? Anything else we should know?

After running php ./core/scripts/drupal quick-start standard, it listed the link to the development server as:
Drupal development server started: <http://127.0.0.1:8888>
and a one-time link at the same URL. However, it did not work and needed to instead use the URL provided by my Lando installation.

Also needed to add "DrupalCon Pittsburgh 2023" Issue Tag, not provided in the Let Us Know How It Went link.

πŸ› Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States fizcs3 Omaha, Nebraska; USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @fizcs3
  • Status changed to Needs work over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    Let's see if this warning:

    Warning message
    Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might affect the eligibility for automatic updates.
    
        Possible database updates have been detected in the following extensions.
            System
            User
    

    actually made sense:

    $ git diff 10.0.0 10.0.9 -- core/modules/system/system.install
    diff --git a/core/modules/system/system.install b/core/modules/system/system.install
    index d692ad8cd5..4bbf4b34ed 100644
    --- a/core/modules/system/system.install
    +++ b/core/modules/system/system.install
    @@ -570,34 +570,6 @@ function system_requirements($phase) {
         }
       }
     
    -  // Test with PostgreSQL databases for the status of the pg_trgm extension.
    -  if ($phase === 'runtime' || $phase === 'update') {
    -    if (Database::isActiveConnection()) {
    -      $connection = Database::getConnection();
    -
    -      // Set the requirement just for postgres.
    -      if ($connection->driver() == 'pgsql') {
    -        $requirements['pgsql_extension_pg_trgm'] = [
    -          'severity' => REQUIREMENT_OK,
    -          'title' => t('PostgreSQL pg_trgm extension'),
    -          'value' => t('Available'),
    -          'description' => 'The pg_trgm PostgreSQL extension is present.',
    -        ];
    -
    -        // If the extension is not available, set the requirement error.
    -        if (!$connection->schema()->extensionExists('pg_trgm')) {
    -          $requirements['pgsql_extension_pg_trgm']['severity'] = REQUIREMENT_ERROR;
    -          $requirements['pgsql_extension_pg_trgm']['value'] = t('Not created');
    -          $requirements['pgsql_extension_pg_trgm']['description'] = t('The <a href=":pg_trgm">pg_trgm</a> PostgreSQL extension is not present. The extension is required by Drupal 10 to improve performance when using PostgreSQL. See <a href=":requirements">Drupal database server requirements</a> for more information.', [
    -            ':pg_trgm' => 'https://www.postgresql.org/docs/current/pgtrgm.html',
    -            ':requirements' => 'https://www.drupal.org/docs/system-requirements/database-server-requirements',
    -          ]);
    -        }
    -
    -      }
    -    }
    -  }
    -
       if ($phase === 'runtime' || $phase === 'update') {
         // Test database JSON support.
         $requirements['database_support_json'] = [
    @@ -784,7 +756,7 @@ function system_requirements($phase) {
               '#suffix' => ' ',
             ],
             [
    -          '#markup' => t('For more information, see the online handbook entry for <a href=":cron-handbook">configuring cron jobs</a>.', [':cron-handbook' => 'https://www.drupal.org/cron']),
    +          '#markup' => t('For more information, see the online handbook entry for <a href=":cron-handbook">configuring cron jobs</a>.', [':cron-handbook' => 'https://www.drupal.org/docs/administering-a-drupal-site/cron-automated-tasks/cron-automated-tasks-overview']),
               '#suffix' => ' ',
             ],
           ];
    @@ -1081,7 +1053,8 @@ function system_requirements($phase) {
             // Check for an incompatible version.
             $required_file = $files[$required_module];
             $required_name = $required_file->info['name'];
    -        $version = str_replace(\Drupal::CORE_COMPATIBILITY . '-', '', $required_file->info['version'] ?? '');
    +        // Remove CORE_COMPATIBILITY- only from the start of the string.
    +        $version = preg_replace('/^(' . \Drupal::CORE_COMPATIBILITY . '\-)/', '', $required_file->info['version'] ?? '');
             if (!$requirement->isCompatible($version)) {
               $requirements["$extension_name-$required_module"] = [
                 'title' => t('Unresolved dependency'),
    

    and:

    $ git diff 10.0.0 10.0.9 -- core/modules/user/user.install
    $
    

    Looks like at least User should not have been mentioned in that list. πŸ€”πŸ˜…

    I think this makes πŸ“Œ Use static analysis to detect new update functions, to reduce false positives in StagedDBUpdateValidator Fixed more important.

  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tedbow Ithaca, NY, USA
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024