- Issue created by @fizcs3
- Status changed to Needs work
over 1 year ago 11:23am 12 June 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Let's see if this warning:
Warning message Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might affect the eligibility for automatic updates. Possible database updates have been detected in the following extensions. System User
actually made sense:
$ git diff 10.0.0 10.0.9 -- core/modules/system/system.install diff --git a/core/modules/system/system.install b/core/modules/system/system.install index d692ad8cd5..4bbf4b34ed 100644 --- a/core/modules/system/system.install +++ b/core/modules/system/system.install @@ -570,34 +570,6 @@ function system_requirements($phase) { } } - // Test with PostgreSQL databases for the status of the pg_trgm extension. - if ($phase === 'runtime' || $phase === 'update') { - if (Database::isActiveConnection()) { - $connection = Database::getConnection(); - - // Set the requirement just for postgres. - if ($connection->driver() == 'pgsql') { - $requirements['pgsql_extension_pg_trgm'] = [ - 'severity' => REQUIREMENT_OK, - 'title' => t('PostgreSQL pg_trgm extension'), - 'value' => t('Available'), - 'description' => 'The pg_trgm PostgreSQL extension is present.', - ]; - - // If the extension is not available, set the requirement error. - if (!$connection->schema()->extensionExists('pg_trgm')) { - $requirements['pgsql_extension_pg_trgm']['severity'] = REQUIREMENT_ERROR; - $requirements['pgsql_extension_pg_trgm']['value'] = t('Not created'); - $requirements['pgsql_extension_pg_trgm']['description'] = t('The <a href=":pg_trgm">pg_trgm</a> PostgreSQL extension is not present. The extension is required by Drupal 10 to improve performance when using PostgreSQL. See <a href=":requirements">Drupal database server requirements</a> for more information.', [ - ':pg_trgm' => 'https://www.postgresql.org/docs/current/pgtrgm.html', - ':requirements' => 'https://www.drupal.org/docs/system-requirements/database-server-requirements', - ]); - } - - } - } - } - if ($phase === 'runtime' || $phase === 'update') { // Test database JSON support. $requirements['database_support_json'] = [ @@ -784,7 +756,7 @@ function system_requirements($phase) { '#suffix' => ' ', ], [ - '#markup' => t('For more information, see the online handbook entry for <a href=":cron-handbook">configuring cron jobs</a>.', [':cron-handbook' => 'https://www.drupal.org/cron']), + '#markup' => t('For more information, see the online handbook entry for <a href=":cron-handbook">configuring cron jobs</a>.', [':cron-handbook' => 'https://www.drupal.org/docs/administering-a-drupal-site/cron-automated-tasks/cron-automated-tasks-overview']), '#suffix' => ' ', ], ]; @@ -1081,7 +1053,8 @@ function system_requirements($phase) { // Check for an incompatible version. $required_file = $files[$required_module]; $required_name = $required_file->info['name']; - $version = str_replace(\Drupal::CORE_COMPATIBILITY . '-', '', $required_file->info['version'] ?? ''); + // Remove CORE_COMPATIBILITY- only from the start of the string. + $version = preg_replace('/^(' . \Drupal::CORE_COMPATIBILITY . '\-)/', '', $required_file->info['version'] ?? ''); if (!$requirement->isCompatible($version)) { $requirements["$extension_name-$required_module"] = [ 'title' => t('Unresolved dependency'),
and:
$ git diff 10.0.0 10.0.9 -- core/modules/user/user.install $
Looks like at least
User
should not have been mentioned in that list. π€πI think this makes π Use static analysis to detect new update functions, to reduce false positives in StagedDBUpdateValidator Fixed more important.
- πΊπΈUnited States tedbow Ithaca, NY, USA
@FizCS3 thanks for testing re #2 I also created you on π Use static analysis to detect new update functions, to reduce false positives in StagedDBUpdateValidator Fixed
- Status changed to Fixed
over 1 year ago 7:56pm 12 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.