- Issue created by @robbt
- Assigned to tedbow
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
AFAICT this means we need to add a validator for this.
I think we need this logic (pseudocode!):
IF ($project root !== $web_root)
AND IF (isset($open_base_dir))
AND IF ($project_root !== $open_basedir)
THEN throw a validation error, because Automatic Updates cannot possibly work.
Simultaneously we should ensure that if the project root is the web root, that we do not try to access the parent, because then we're violating the
open_basedir
restriction unnecessarily. - ๐ฎ๐ณIndia omkar.podey
omkar.podey โ made their first commit to this issueโs fork.
- Assigned to omkar.podey
- ๐ฎ๐ณIndia omkar.podey
I'll start writing the validator based on Wim's pseudocode using
ini_get('open_basedir')
to get all paths that are defined. - last update
over 1 year ago 810 pass, 2 fail - @omkarpodey opened merge request.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 1:33pm 16 June 2023 - ๐ฎ๐ณIndia omkar.podey
@robbt, thanks for reporting this, I have a few questions , so we always want to always search paths inside of the project root, so did your site run at all with
open_basedir
set ? , other reason could be public and private file paths as our validators would look at those, i would like to know if this is set$settings['file_private_path']
and to what value ? - ๐บ๐ธUnited States robbt
So the site has been running fine with open_basedir set. I did not set the file_private_path and the public path is just sites/default/files
It appears to want to check the directory above the directory where composer.json etc. is installed.