- Issue created by @phenaproxima
- last update
over 1 year ago 792 pass, 4 fail - @phenaproxima opened merge request.
- last update
over 1 year ago 800 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 6:02pm 7 June 2023 - last update
over 1 year ago 798 pass, 2 fail - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Wim Leers β made their first commit to this issueβs fork.
- last update
over 1 year ago 800 pass - Status changed to Needs work
over 1 year ago 10:28am 12 June 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Pushed fix for failing tests, but this still needs work to ensure this doesn't interfere with generating the core MR.
- Status changed to Needs review
over 1 year ago 2:19pm 12 June 2023 - πΊπΈUnited States phenaproxima Massachusetts
Still to be done: automatically omitting the automatic_updates_extensions piece from the core MR.
Why? It's inside a
DELETE FROM CORE MERGE REQUEST
block already, so I think this is taken care of...? - last update
over 1 year ago 800 pass - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 3:05pm 12 June 2023 - last update
over 1 year ago 800 pass - last update
over 1 year ago 800 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 3:56pm 12 June 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 4:09pm 12 June 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Ugghh. this is tricky. see MR comment
- last update
over 1 year ago 800 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 4:25pm 12 June 2023 - last update
over 1 year ago 800 pass - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 4:55pm 12 June 2023 - last update
over 1 year ago 800 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 4:57pm 12 June 2023 - Status changed to RTBC
over 1 year ago 4:58pm 12 June 2023 - Issue was unassigned.
- last update
over 1 year ago 800 pass -
phenaproxima β
committed fc7a3966 on 3.0.x
Issue #3365414 by phenaproxima, Wim Leers, tedbow: Don't declare...
-
phenaproxima β
committed fc7a3966 on 3.0.x
- Status changed to Fixed
over 1 year ago 5:21pm 12 June 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Q: why did this MR merge these 2 lines?
- $output = $this->runComposer('COMPOSER_MIRROR_PATH_REPOS=1 composer require psr/http-message', $dir); - $output = $this->runComposer('COMPOSER_MIRROR_PATH_REPOS=1 composer require --update-with-all-dependencies "drupal/automatic_updates:@dev"', $dir); + $output = $this->runComposer('COMPOSER_MIRROR_PATH_REPOS=1 composer require --update-with-all-dependencies psr/http-message "drupal/automatic_updates:@dev"', $dir);
- πΊπΈUnited States phenaproxima Massachusetts
That change is technically unrelated, but it was clearly a mistake when it was made, because $output is immediately overwritten -- and then something is asserted against it. To prevent accidental errors in the first call to runComposer(), we should have combined them into a single call so we can do the assertion on the combined, full $output.
Automatically closed - issue fixed for 2 weeks with no activity.