PHP 8.2 - dynamic property creation is deprecated

Created on 7 June 2023, about 1 year ago
Updated 25 June 2023, 12 months ago

Problem/Motivation

I'm using CSP as a dependency in some of my module's tests.

The drupal.org test bot is failing the test with this exception ( https://www.drupal.org/pift-ci-job/2685966 β†’ ):

1) Drupal\Tests\inline_all_css\Functional\CspTest::testCspIntegration
Exception: Deprecated function: Creation of dynamic property Drupal\csp_extras\Ajax\AjaxResponseAttachmentsProcessor::$renderer is deprecated
Drupal\csp_extras\Ajax\AjaxResponseAttachmentsProcessor->__construct()() (Line: 113)


/var/www/html/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:47
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:204
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:153
/var/www/html/vendor/guzzlehttp/promises/src/TaskQueue.php:48
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:248
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:224
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:269
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:226
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:62
/var/www/html/vendor/guzzlehttp/guzzle/src/Client.php:187
/var/www/html/core/tests/Drupal/Tests/DrupalTestBrowser.php:137
/var/www/html/vendor/symfony/browser-kit/AbstractBrowser.php:403
/var/www/html/vendor/symfony/browser-kit/AbstractBrowser.php:603
/var/www/html/vendor/symfony/browser-kit/AbstractBrowser.php:421
/var/www/html/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:111
/var/www/html/vendor/behat/mink/src/Session.php:148
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:281
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:251
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:370
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

This likely won't affect end-users , but it'd be nice to resolve if it's quick and easy.

Steps to reproduce

Use csp on PHP 8.2 -- see https://www.drupal.org/pift-ci-job/2685966 β†’

Proposed resolution

Add a member $renderer property to the \Drupal\csp_extras\Ajax\AjaxResponseAttachmentsProcessor class.

Remaining tasks

  1. Run a baseline test against CSP on php8.2 and get the exception to happen in this project.
  2. Fix the problem.
  3. Confirm that the upstream CI test run starts completing.

User interface changes

None

API changes

None

Data model changes

None

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Luke.Leber Pennsylvania

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024